Revert "Use string[] for Options.assemblyNames"

This reverts commit 8e1d0e3.

Author: rogerbarton

scripts/DllManipulator.cs

@@ -654,7 +654,7 @@ private static IntPtr SysGetDllProcAddress(IntPtr libHandle, string symbol)
     public class DllManipulatorOptions
     {
         public string dllPathPattern;
-        public string[] assemblyNames; // empty means only default assemblies
+        public List<string> assemblyNames; // empty means only default assemblies
         public DllLoadingMode loadingMode;
         public PosixDlopenFlags posixDlopenFlags;
         public bool threadSafe;

scripts/DllManipulatorScript.cs

@@ -28,7 +28,7 @@ public class DllManipulatorScript : MonoBehaviour
 #else // UNITY_STANDALONE_WIN Windows fallback
             "{assets}/Plugins/__{name}.dll",
 #endif
-            assemblyNames = new string[0],
+            assemblyNames = new List<string>(),
             loadingMode = DllLoadingMode.Lazy,
             posixDlopenFlags = PosixDlopenFlags.Lazy,
             threadSafe = false,

scripts/Editor/DllManipulatorEditor.cs

@@ -195,9 +195,9 @@ private void DrawOptions(DllManipulatorOptions options)
 
             options.mockAllNativeFunctions = EditorGUILayout.Toggle(TARGET_ALL_NATIVE_FUNCTIONS_GUI_CONTENT, options.mockAllNativeFunctions);
 
-            if (EditorGUILayout.Toggle(ONLY_ASSEMBLY_CSHARP_GUI_CONTENT, options.assemblyNames.Length == 0))
+            if (EditorGUILayout.Toggle(ONLY_ASSEMBLY_CSHARP_GUI_CONTENT, options.assemblyNames.Count == 0))
             {
-                options.assemblyNames = new string[0];
+                options.assemblyNames.Clear();
             }
             else
             {
@@ -207,8 +207,8 @@ private void DrawOptions(DllManipulatorOptions options)
                 if (_allKnownAssemblies == null || _lastKnownAssembliesRefreshTime + ASSEMBLIES_REFRESH_INTERVAL < DateTime.Now)
                     RefreshAllKnownAssemblies();
 
-                if (options.assemblyNames.Length == 0)
-                    options.assemblyNames = DllManipulator.DEFAULT_ASSEMBLY_NAMES;
+                if (options.assemblyNames.Count == 0)
+                    options.assemblyNames.AddRange(DllManipulator.DEFAULT_ASSEMBLY_NAMES);
 
                 _showTargetAssemblies = EditorGUILayout.Foldout(_showTargetAssemblies, TARGET_ASSEMBLIES_GUI_CONTENT);
                 if (_showTargetAssemblies)
@@ -231,7 +231,7 @@ private void DrawOptions(DllManipulatorOptions options)
                         () =>
                         {
                             options.assemblyNames = options.assemblyNames
-                                .Concat(_allKnownAssemblies).Distinct().ToArray();
+                                .Concat(_allKnownAssemblies).Distinct().ToList();
                         });
 
                     EditorGUI.indentLevel = prevIndent2;