Mark scene dirty only if options changed

Author: rogerbarton

scripts/DllManipulator.cs

@@ -692,6 +692,33 @@ public class DllManipulatorOptions
         public bool mockAllNativeFunctions;
         public bool onlyInEditor;
         public bool enableInEditMode;
+
+        public DllManipulatorOptions CloneTo(DllManipulatorOptions other)
+        {
+            other.dllPathPattern = dllPathPattern;
+            other.assemblyNames = (string[]) assemblyNames.Clone();
+            other.loadingMode = loadingMode;
+            other.posixDlopenFlags = posixDlopenFlags;
+            other.threadSafe = threadSafe;
+            other.enableCrashLogs = enableCrashLogs;
+            other.crashLogsDir = crashLogsDir;
+            other.crashLogsStackTrace = crashLogsStackTrace;
+            other.mockAllNativeFunctions = mockAllNativeFunctions;
+            other.onlyInEditor = onlyInEditor;
+            other.enableInEditMode = enableInEditMode;
+            
+            return other;
+        }
+
+        public bool Equals(DllManipulatorOptions other)
+        {
+            return other.dllPathPattern == dllPathPattern && other.assemblyNames.SequenceEqual(assemblyNames) &&
+                   other.loadingMode == loadingMode && other.posixDlopenFlags == posixDlopenFlags &&
+                   other.threadSafe == threadSafe && other.enableCrashLogs == enableCrashLogs &&
+                   other.crashLogsDir == crashLogsDir && other.crashLogsStackTrace == crashLogsStackTrace &&
+                   other.mockAllNativeFunctions == mockAllNativeFunctions && other.onlyInEditor == onlyInEditor &&
+                   other.enableInEditMode == enableInEditMode;
+        }
     }
 
     public enum DllLoadingMode

scripts/Editor/DllManipulatorEditor.cs

@@ -63,6 +63,11 @@ public class DllManipulatorEditor : Editor
         private bool _showTargetAssemblies = true;
         private string[] _allKnownAssemblies = null;
         private DateTime _lastKnownAssembliesRefreshTime;
+
+        /// <summary>
+        /// To check if the options have change in order to set the object as dirty
+        /// </summary>
+        private DllManipulatorOptions _prevOptions = new DllManipulatorOptions();
 
         public static event Action RepaintAllEditors = delegate {};
 
@@ -72,6 +77,11 @@ public DllManipulatorEditor()
             EditorApplication.playModeStateChanged += _ => Repaint();
             RepaintAllEditors += Repaint;
         }
+        
+        private void Awake()
+        {
+            ((DllManipulatorScript)target).Options.CloneTo(_prevOptions);
+        }
 
         public override void OnInspectorGUI()
         {
@@ -147,9 +157,14 @@ public override void OnInspectorGUI()
                 EditorGUILayout.LabelField($"Initialized in: {(int)time.TotalSeconds}.{time.Milliseconds.ToString("D3")}s");
             }
 
+            // Set the target as dirty so changes can be saved, if there are changes
             if (GUI.changed)
             {
-                EditorUtility.SetDirty(target);
+                if (!t.Options.Equals(_prevOptions))
+                {
+                    t.Options.CloneTo(_prevOptions);
+                    EditorUtility.SetDirty(target);
+                }
             }
         }